INT-4520 Make IntegrationGraphServer customizable #2608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
garyrussell
suggested changes
Oct 24, 2018
| /** | ||
| * Get beans for provided type from the application context. | ||
| * This method can be extended for some custom logic, e.g. get beans | ||
| * form the parent application context as well. |
There was a problem hiding this comment.
typo form
for the provided type
| * @param value the value of the property | ||
| * @since 5.1 | ||
| */ | ||
| public void addProperty(String name, Object value) { |
src/reference/asciidoc/graph.adoc
Outdated
| @@ -147,6 +147,25 @@ It is also used in the `links` element to represent a relationship (connection) | |||
| The `input` and `output` attributes are for the `inputChannel` and `outputChannel` properties of the `AbstractEndpoint`, `MessageHandler`, `SourcePollingChannelAdapter`, or `MessageProducerSupport`. | |||
| See the next section for more information. | |||
|
|
|||
| Starting with version 5.1, the `IntegrationGraphServer` accepts a `Function<NamedComponent, Map<String, Object>> additionalPropertiesCallback` for population additional properties on the `IntegrationNode` for particular `NamedComponent`. | |||
There was a problem hiding this comment.
for population of additional
for a particular
| @@ -147,6 +147,25 @@ It is also used in the `links` element to represent a relationship (connection) | |||
| The `input` and `output` attributes are for the `inputChannel` and `outputChannel` properties of the `AbstractEndpoint`, `MessageHandler`, `SourcePollingChannelAdapter`, or `MessageProducerSupport`. | |||
| See the next section for more information. | |||
|
|
|||
| Starting with version 5.1, the `IntegrationGraphServer` accepts a `Function<NamedComponent, Map<String, Object>> additionalPropertiesCallback` for population additional properties on the `IntegrationNode` for particular `NamedComponent`. | |||
| For example you can expose a `SmartLifecycle` `autoStartup` and `running` properties into the target graph: | |||
|
|
|||
| @@ -210,3 +210,9 @@ e.g. `org.springframework.integration:type=MessageChannel,` `name="input#foo.myG | |||
|
|
|||
| It is now simpler to customize the standard Micrometer meters created by the framework. | |||
| See <<micrometer-integration>> for more information. | |||
|
|
|||
| [[x51.-integration-graph]] | |||
| === The Integration Graph Customization | |||
| @@ -76,6 +81,27 @@ public Stats getStats() { | |||
| return this.properties.size() == 0 ? null : this.properties; | |||
There was a problem hiding this comment.
@Nullable on this getter? Or, maybe we should just always return it, even if empty.
Also, now that we have a mechanism to modify the map, maybe we should return an UnmodifableMap - if so, it should be a field instead of wrapping the map on every call.
There was a problem hiding this comment.
Do you mean we should use a BiConsumer<NamedComponent, Map<String, Object>> instead of that Function for additional properties?
There was a problem hiding this comment.
?
No; I just mean that now we have IN.addProperty() and addProperties() we no longer need to expose a direct reference to properties field.
garyrussell
approved these changes
Oct 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: https://jira.spring.io/browse/INT-4520